feat: split `AllocationManager` #1643

0xClandestine · 2025-09-30T18:57:32Z

Motivation:

The AllocationManager contract was hitting the 24KB bytecode size limit, which would have blocked deployment. We needed a solution to reduce the contract size while maintaining backwards compatibility with existing integrations that call view functions on AllocationManager.

Modifications:

Created a new SplitContractMixin that uses a fallback to delegate unmatched function calls via delegatecall to a secondary contract
Split AllocationManager into two contracts: the main contract handles state-mutating operations, while AllocationManagerView handles all read-only view functions
Both contracts inherit from AllocationManagerStorage to share the same storage layout, enabling the view contract to read from the main contract's storage
Updated AllocationManager constructor to accept and store the AllocationManagerView address
Modified all deployment scripts (devnet, local, integration) to deploy both proxies and implementations
Updated ExistingDeploymentParser, test harnesses, and unit/integration tests to work with the split architecture

Result:

The AllocationManager is now about ~ 4.8KB under the 24KB limit with room to grow.
The AllocationManagerView contract has 16KB of available space for future view functions.

TODO: Add a ci check (I don't have privs but the code is written locally)

Get list of all contracts ending in View.sol in the repo.
Use forge inspect abi and check all mutability fields == view|pure.
Basic search over the file to see if sstore or delegatecall is used on a for additional sanity.

src/contracts/interfaces/IExtsload.sol

src/contracts/core/AllocationManager.sol

src/contracts/interfaces/IAllocationManager.sol

src/contracts/interfaces/IExtsload.sol

src/contracts/mixins/SplitContractMixin.sol

foundry.toml

feat: split alm wip wip wip wip wip wip wip unit tests passing remove extsload wip tests passing chore: git mv storage to folder wip ci docs todo cleanup ci ci rename `secondHalf` rm extsload move storage add protocol registry to zeus

src/contracts/core/AllocationManagerView.sol

src/test/DevnetLifecycle.t.sol

src/contracts/mixins/SplitContractMixin.sol

src/contracts/core/storage/AllocationManagerStorage.sol

src/test/integration/tests/ALM_Multi.t.sol

src/test/integration/tests/upgrade/AllocationManagerUpgrade.t.sol

src/contracts/core/AllocationManager.sol

script/deploy/local/deploy_from_scratch.slashing.s.sol

src/test/integration/users/AVS.t.sol

0xrajath · 2025-10-20T22:41:47Z

src/test/unit/SplitContractMixin.t.sol

Can we get some tests here to ensure that only view functions can be delegate called? And revert otherwise.

Bit of an odd thing to test, since the compiler explicitly does this.

Tests for this would actually fail. If the delegate implements a non-view function, it can be called with delegateView successfully. _delegateView does not enforce that delegate calls do not modify state; it's more of a suggestion that the underlying function doesn't modify state.

If you're curious, try plugging the below code block into SplitContractMixin.t.sol locally, and run forge t SplitContractMixin.t.sol. You'll see that test_setValue passes, indicating that setValue (which is a view function and uses delegateView) is able to execute a state-modifying operation.

// rest of SplitContractMixinTest above function setValue(uint) public view returns (uint result) { _delegateView(address(delegate)); result; } function test_setValue() public { (bool success, bytes memory data) = address(this).call(abi.encodeWithSelector(this.setValue.selector, 100)); assertTrue(success); (bool success, bytes memory data) = address(this).call(abi.encodeWithSelector(this.getValue.selector)); assertTrue(success); uint result = abi.decode(data, (uint)); assertEq(result, 100); } } // Mock contract to test delegation contract Delegate is Test { uint value; function getValue() public view returns (uint result) { return value; } function setValue(uint _value) public { value = _value; } }

@nadir-akhtar We're talking about different things here, @0xrajath was suggesting adding tests to confirm that if we send calldata with a selector that's unknown to the view contract it reverts. I'm saying it's standard solidity behavior for a contract to revert if the functions unrecognized.

src/test/integration/tests/upgrade/AllocationManagerUpgrade.t.sol

nadir-akhtar

Split looks like a solid start! Especially with the layout at <storage slot> syntax making this super convenient.

A few notes on lingering TODOs, as well as some room for clarification in our docs on _delegateView allowing for delegatecall effects that may change state if the delegate contract implements such a function.

docs/core/AllocationManager.md

src/test/integration/tests/ALM_Multi.t.sol

src/contracts/core/AllocationManagerView.sol

src/test/unit/AllocationManagerUnit.t.sol

nadir-akhtar · 2025-10-22T00:29:09Z

src/test/unit/SplitContractMixin.t.sol

Tests for this would actually fail. If the delegate implements a non-view function, it can be called with delegateView successfully. _delegateView does not enforce that delegate calls do not modify state; it's more of a suggestion that the underlying function doesn't modify state.

If you're curious, try plugging the below code block into SplitContractMixin.t.sol locally, and run forge t SplitContractMixin.t.sol. You'll see that test_setValue passes, indicating that setValue (which is a view function and uses delegateView) is able to execute a state-modifying operation.

// rest of SplitContractMixinTest above function setValue(uint) public view returns (uint result) { _delegateView(address(delegate)); result; } function test_setValue() public { (bool success, bytes memory data) = address(this).call(abi.encodeWithSelector(this.setValue.selector, 100)); assertTrue(success); (bool success, bytes memory data) = address(this).call(abi.encodeWithSelector(this.getValue.selector)); assertTrue(success); uint result = abi.decode(data, (uint)); assertEq(result, 100); } } // Mock contract to test delegation contract Delegate is Test { uint value; function getValue() public view returns (uint result) { return value; } function setValue(uint _value) public { value = _value; } }

src/test/utils/Logger.t.sol

…it-alm

nadir-akhtar

Looks good! Much needed improvement to our contract codesize 💪

ypatil12

LGTM, left one non-blocking comment

ypatil12 · 2025-10-23T18:58:09Z

src/test/integration/tests/upgrade/AllocationManagerUpgrade.t.sol

+        check_IncrAlloc_State_Slashable(operator, allocateParams);
+
+        // 7. Roll blocks to complete allocation
+        _rollBlocksForCompleteAllocation(operator, operatorSet, strategies);


Can we also slash here just for completeness to write to every (I think?) slot

will do in semver removal pr for sake of avoiding collecting approvals again

**Motivation:** The `AllocationManager` contract was hitting the 24KB bytecode size limit, which would have blocked deployment. We needed a solution to reduce the contract size while maintaining backwards compatibility with existing integrations that call view functions on `AllocationManager`. **Modifications:** - Created a new `SplitContractMixin` that uses a fallback to delegate unmatched function calls via `delegatecall` to a secondary contract - Split `AllocationManager` into two contracts: the main contract handles state-mutating operations, while `AllocationManagerView` handles all read-only view functions - Both contracts inherit from `AllocationManagerStorage` to share the same storage layout, enabling the view contract to read from the main contract's storage - Updated `AllocationManager` constructor to accept and store the `AllocationManagerView` address - Modified all deployment scripts (devnet, local, integration) to deploy both proxies and implementations - Updated `ExistingDeploymentParser`, test harnesses, and unit/integration tests to work with the split architecture **Result:** - The `AllocationManager` is now about ~ 4.8KB under the 24KB limit with room to grow. - The `AllocationManagerView` contract has 16KB of available space for future view functions. TODO: Add a ci check (I don't have privs but the code is written locally) 1) Get list of all contracts ending in View.sol in the repo. 2) Use forge inspect abi and check all mutability fields == view|pure. 3) Basic search over the file to see if sstore or delegatecall is used on a for additional sanity. --------- Co-authored-by: eigenmikem <[email protected]> squash squash feat: split alm wip wip wip wip wip wip wip unit tests passing remove extsload wip tests passing chore: git mv storage to folder wip ci docs todo cleanup ci ci rename `secondHalf` rm extsload move storage add protocol registry to zeus squash feat: split alm wip wip wip wip wip wip wip unit tests passing remove extsload wip tests passing chore: git mv storage to folder wip ci wip wip wip wip wip remove extsload wip tests passing wip passing perf: wrap modifier logic to save codesize chore: forge fmt refactor: remove semver (#1641) **Motivation:** We want to consolidate semver logic into a single purpose built contract. **Modifications:** - Removed `SemVerMixin` import from all contracts. **Result:** More codesize savings. make fmt refactor: expand `ProtocolRegistry` to list all contracts + pause rm gas snapshots rm extsload rebase ci revert eigen changes remove stale scripts

**Motivation:** The `AllocationManager` contract was hitting the 24KB bytecode size limit, which would have blocked deployment. We needed a solution to reduce the contract size while maintaining backwards compatibility with existing integrations that call view functions on `AllocationManager`. **Modifications:** - Created a new `SplitContractMixin` that uses a fallback to delegate unmatched function calls via `delegatecall` to a secondary contract - Split `AllocationManager` into two contracts: the main contract handles state-mutating operations, while `AllocationManagerView` handles all read-only view functions - Both contracts inherit from `AllocationManagerStorage` to share the same storage layout, enabling the view contract to read from the main contract's storage - Updated `AllocationManager` constructor to accept and store the `AllocationManagerView` address - Modified all deployment scripts (devnet, local, integration) to deploy both proxies and implementations - Updated `ExistingDeploymentParser`, test harnesses, and unit/integration tests to work with the split architecture **Result:** - The `AllocationManager` is now about ~ 4.8KB under the 24KB limit with room to grow. - The `AllocationManagerView` contract has 16KB of available space for future view functions. TODO: Add a ci check (I don't have privs but the code is written locally) 1) Get list of all contracts ending in View.sol in the repo. 2) Use forge inspect abi and check all mutability fields == view|pure. 3) Basic search over the file to see if sstore or delegatecall is used on a for additional sanity. --------- Co-authored-by: eigenmikem <[email protected]>

ypatil12 reviewed Oct 1, 2025

View reviewed changes

src/contracts/interfaces/IExtsload.sol Outdated Show resolved Hide resolved

ypatil12 changed the base branch from main to release/slashing-ux-improvements October 1, 2025 21:56

ypatil12 changed the base branch from release/slashing-ux-improvements to release-dev/slashing-ux-improvements October 2, 2025 14:55

0xClandestine force-pushed the refactor/split-alm branch from e64c0f7 to 7dc8bb1 Compare October 7, 2025 19:43

0xClandestine changed the title ~~draft: split AllocationManager~~ feat: split AllocationManager Oct 7, 2025

0xClandestine force-pushed the refactor/split-alm branch from bec851a to 7dc8bb1 Compare October 9, 2025 17:02

0xClandestine requested a review from ypatil12 October 9, 2025 19:18

0xClandestine force-pushed the refactor/split-alm branch from 7dc8bb1 to b480b22 Compare October 9, 2025 19:28

ypatil12 reviewed Oct 9, 2025

View reviewed changes

ypatil12 force-pushed the release-dev/slashing-ux-improvements branch from bce9cbb to c572ec5 Compare October 15, 2025 18:39

0xClandestine force-pushed the refactor/split-alm branch 2 times, most recently from 99855a2 to c676cd8 Compare October 15, 2025 19:53

0xClandestine requested review from 0xrajath, eigenmikem and nadir-akhtar October 15, 2025 20:30

squash

ecc69cf

feat: split alm wip wip wip wip wip wip wip unit tests passing remove extsload wip tests passing chore: git mv storage to folder wip ci docs todo cleanup ci ci rename `secondHalf` rm extsload move storage add protocol registry to zeus

0xClandestine force-pushed the refactor/split-alm branch from 42af1f1 to ecc69cf Compare October 16, 2025 15:14

ypatil12 reviewed Oct 16, 2025

View reviewed changes

src/contracts/core/AllocationManagerView.sol Outdated Show resolved Hide resolved

src/test/DevnetLifecycle.t.sol Show resolved Hide resolved

src/contracts/mixins/SplitContractMixin.sol Show resolved Hide resolved

0xClandestine added 4 commits October 16, 2025 11:41

test

b5fa797

doc storage layout

ec8e978

simplify split contract tests

5b95c0e

upgrade storage test

684c758

eigenmikem reviewed Oct 17, 2025

View reviewed changes

src/contracts/core/storage/AllocationManagerStorage.sol Outdated Show resolved Hide resolved

0xClandestine added 4 commits October 17, 2025 12:05

docs

c3b1a53

nit

00e046e

comment flakey test

46b6b25

make fmt

0559525

ypatil12 reviewed Oct 17, 2025

View reviewed changes

src/test/integration/tests/ALM_Multi.t.sol Outdated Show resolved Hide resolved

src/test/integration/tests/upgrade/AllocationManagerUpgrade.t.sol Outdated Show resolved Hide resolved

0xClandestine added 2 commits October 20, 2025 16:09

test

0acd9bb

test

007a97d